From: Derrick Stolee Date: Wed, 15 Mar 2023 16:18:53 GMT Subject: Re: [PATCH v2 8/8] commit-reach: add tips_reachable_from_bases() Message-ID: <973033ff-940c-01d9-bb8f-5722591988de@github.com> In-Reply-To: On 3/15/2023 12:17 PM, Derrick Stolee wrote: > On 3/15/2023 10:13 AM, Ævar Arnfjörð Bjarmason wrote: >> >> On Fri, Mar 10 2023, Derrick Stolee via GitGitGadget wrote: >> >>> From: Derrick Stolee > Not only does the previous message note this perf test, it has this to say: > > The 'git rev-list' test exists in this change as a demonstration, but it > will be removed in the next change to avoid wasting time on this > comparison. > >> And here for a supposed optimization commit you're adding new tests, but >> when I try them with the C code at 7/8 they pass. >> >> So it seems we should add them earlier, and this is a pure-optimization >> commit, but one that's a bit confused about what goes where? :) > > I can make it more clear why we are removing it in this commit. Oh wait, I did: >> (Note that we remove the iterative 'git rev-list' test from p1500 >> because it no longer makes sense as a comparison to 'git for-each-ref' >> and would just waste time running it for these comparisons.) Thanks, -Stolee