From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Sun, 24 Mar 2024 17:04:34 GMT
Subject: Re: [PATCH] t/README: mention test files are make targets
Message-ID: <97212b72-70d6-e55f-8b2a-04ede4321288@gmail.com>
In-Reply-To: <xmqq4jcvtxtz.fsf@gitster.g>

Hi Junio,

Le 2024-03-24 à 12:10, Junio C Hamano a écrit :
> "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>>
>> Since 23fc63bf8f (make tests ignorable with "make -i", 2005-11-08), each
>> test file defines a target in the test Makefile, such that one can
>> invoke:
>>
>> 	make *checkout*
>>
>> to run all tests with 'checkout' in their filename. This is useful to
>> run a subset of tests when you have a good idea of what part of the code
>> is touched by the changes your are testing.
> 
> While I agree with the patch that this is a useful "feature" of
> t/Makefile, I've always felt it was ugly to use a file itself that
> we do not consider a build product, rather a source, as the target
> to trigger some action.  Are we comfortable casting this behaviour
> in stone by documenting it here?

Since '$(T)' is listed at the bottom of the Makefile as .PHONY,
I think it is OK and not that ugly since this uses a documented feature
of make.

Cheers,
Philippe.