From: Jeff Hostetler Date: Mon, 08 May 2017 16:50:51 GMT Subject: Re: [PATCH v7] read-cache: force_verify_index_checksum Message-ID: <962eefec-2ea6-6b43-7bd5-51da4150bb6a@jeffhostetler.com> In-Reply-To: On 5/8/2017 5:45 AM, Christian Couder wrote: > On Fri, Apr 14, 2017 at 10:32 PM, wrote: >> diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh >> index 33a51c9..677e15a 100755 >> --- a/t/t1450-fsck.sh >> +++ b/t/t1450-fsck.sh >> @@ -689,4 +689,17 @@ test_expect_success 'bogus head does not fallback to all heads' ' >> ! grep $blob out >> ' >> >> +test_expect_success 'detect corrupt index file in fsck' ' >> + cp .git/index .git/index.backup && >> + test_when_finished "mv .git/index.backup .git/index" && >> + echo zzzzzzzz >zzzzzzzz && >> + git add zzzzzzzz && >> + sed -e "s/zzzzzzzz/yyyyyyyy/" .git/index >.git/index.yyy && >> + mv .git/index.yyy .git/index && >> + # Confirm that fsck detects invalid checksum >> + test_must_fail git fsck --cache && >> + # Confirm that status no longer complains about invalid checksum >> + git status >> +' > > This test does not pass when the GIT_TEST_SPLIT_INDEX env variable is > set on my Linux machine. > > Also it looks like you sent a v8 of this patch series with a different > test, but what is in master looks like the above test instead of the > test in your v8. > There was concern about using sed on a binary file not being portable and a request to change the test to just corrupt the checksum rather than an index-entry, so I changed it in v8. Does the v8 version of the test also fail on your machine ? Thanks Jeff