From: Ben Keene Date: Sat, 07 Dec 2019 21:27:29 GMT Subject: Re: [PATCH v5 00/15] git-p4.py: Cast byte strings to unicode strings in python3 Message-ID: <95ead4b6-21bb-1aa2-f16f-888e61a4e4c0@gmail.com> In-Reply-To: <20191207194756.GA43949@coredump.intra.peff.net> Yes indeed! I hadn't pulled before I attempted the rebase, and got bit.  Yes those shouldn't be there! On 12/7/2019 2:47 PM, Jeff King wrote: > On Sat, Dec 07, 2019 at 05:47:28PM +0000, Ben Keene via GitGitGadget wrote: > >> Ben Keene (13): >> git-p4: select P4 binary by operating-system >> git-p4: change the expansion test from basestring to list >> git-p4: promote encodeWithUTF8() to a global function >> git-p4: remove p4_write_pipe() and write_pipe() return values >> git-p4: add new support function gitConfigSet() >> git-p4: add casting helper functions for python 3 conversion >> git-p4: python 3 syntax changes >> git-p4: fix assumed path separators to be more Windows friendly >> git-p4: add Py23File() - helper class for stream writing >> git-p4: p4CmdList - support Unicode encoding >> git-p4: support Python 3 for basic P4 clone, sync, and submit (t9800) >> git-p4: added --encoding parameter to p4 clone >> git-p4: Add depot manipulation functions >> >> Jeff King (2): >> t/gitweb-lib.sh: drop confusing quotes >> t/gitweb-lib.sh: set $REQUEST_URI > Hmm, looks like rebasing leftovers. :) I think we can probably drop > these first two? > > -Peff