From: Phillip Wood Date: Mon, 26 Jun 2017 09:17:42 GMT Subject: Re: [PATCH v3 0/4] Add regression tests for recent rebase -i fixes Message-ID: <955e36fb-a6e9-51d4-84b7-b33859c3fe36@talktalk.net> In-Reply-To: On 23/06/17 19:53, Junio C Hamano wrote: > Junio C Hamano writes: > >> 3404 needs a similar fix-up for the series to be able to stand on >> its own. Alternatively, at least we need to understand what in 'pu' >> makes the result of the merge pass---the symptom indicates that this >> topic cannot be merged to a released version without that unknown >> other topic in 'pu' merged if we want to keep POISON build passing >> the tests. > > Ah, no worries. I think I figured it out. > > The topic "rebase -i regression fix", which this "regression fix > tests" builds on, is queued on an older codebase than 0d75bfe6 > ("tests: fix tests broken under GETTEXT_POISON=YesPlease", > 2017-05-05); it is natural these old test breakages can be seen when > the topic is tested alone. Oh, that explains it, I was pretty sure the reflog messages were not translated so couldn't understand why it would fail under GETTEXT_POISON=YesPlease > So we can safely merge this topic down. That's great, thanks for taking the time to track down the reason for the test failure Best Wishes Phillip