From: Ramsay Jones Date: Sun, 12 Jul 2026 13:35:55 GMT Subject: Re: [PATCH] Makefile: fix up lib directory move Message-ID: <94e744f1-12b1-4ba4-8f9b-266c1642b5ff@ramsayjones.plus.com> In-Reply-To: On 12/07/2026 11:15 am, Johannes Schindelin wrote: > Hi Ramsay, > > On Fri, 10 Jul 2026, Ramsay Jones wrote: > >> Commit 9759608622 ("Move libgit.a sources into separate "lib/" directory", > > It's not your fault, but this commit is no longer reachable from any > official branch. Ah, yes, sorry about that! :( I wrote this patch first, on Linux, when 'easing' myself back after the v2.55.0 release. Then I found the cygwin failures ... :) When I eventually sent the cygwin email, some days later, I just tacked this on without thinking. [Usually I send these kind of 'patches' within hours of the branch being published, so that commit IDs are still 'fresh'. However, even such a small window is no guarantee, of course! :) ] > > Maybe a more stable way to refer to this right now would be to name the > topic: `ps/libgit-in-subdir`. Indeed. ;) >> 2026-06-22) moved some files into a lib directory, but forgot to update >> a sparse dependency in the Makefile, resulting in a sparse error: >> >> SP lib/pack-revindex.c >> lib/pack-revindex.c:78:17: error: memset with byte count of 262144 >> make: *** [Makefile:3446: lib/pack-revindex.sp] Error 1 >> >> Add the missing 'lib/' prefix to the pack-revindex.sp path. > > That reasoning and that patch make sense to me. Thank you! > Thanks! ATB, Ramsay Jones