From: Felipe Contreras Date: Tue, 13 Oct 2009 10:02:15 GMT Subject: Re: [PATCH 2/3] git config: clarify bool types Message-ID: <94a0d4530910130302j26c5308ew5266d03c775b6ab0@mail.gmail.com> In-Reply-To: <4AD427AD.3010701@drmicha.warpmail.net> On Tue, Oct 13, 2009 at 10:09 AM, Michael J Gruber wrote: > Felipe Contreras venit, vidit, dixit 12.10.2009 19:14: >> On Mon, Oct 12, 2009 at 3:30 PM, Michael J Gruber >> wrote: >>> Felipe Contreras venit, vidit, dixit 12.10.2009 12:03: >>>> On Mon, Oct 12, 2009 at 8:01 AM, Junio C Hamano wrote: >>>>> Felipe Contreras writes: >>>>> >>>>>> The value is what it is, the --bool and --bool-or-int options don't >>>>>> specify the value type, just how it is interpreted. For example: a value >>>>>> of '1' can be interpreted as 'true'. >>>>> >>>>> It is not really about "interpreting", but about showing, isn't it? >>>> >>>> Unless you are setting it, instead of reading it. >>>> >>> >>> I'd still suggest fixing the typo ("interpreted") and spelling out >>> "boolean". >> >> Oops! You mean s/intepreted/interpreted/? > > Yep :) > >> >> If we spell 'boolean' we might as well spell 'integer'; I think bool >> and int are fine. >> > > "int" is at least a standard type name in C, whereas "bool" is not; but, > yes, feel free to spell out "integer", or use "--int or --bool" as it > is, which is a back reference to the corresponding entries for "--int" > and "--bool", where things should be spelled out. 'bool' is also a standard type, in C99. -- Felipe Contreras