From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 22 Feb 2009 18:38:10 GMT
Subject: Re: [PATCH/RFC 5/6] builtin-tag: add sort by date -D
Message-ID: <94a0d4530902221038j6614bfacl223c0fa7b7be396@mail.gmail.com>
In-Reply-To: <e29894ca0902221006j3d602553x15807b41698f51a1@mail.gmail.com>

On Sun, Feb 22, 2009 at 8:06 PM, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
> Signed-off-by: Marc-Andre Lureau <marcandre.lureau@gmail.com>
> ---
>  builtin-tag.c |  162 +++++++++++++++++++++++++++++++++++++++++++++------------
>  1 files changed, 129 insertions(+), 33 deletions(-)
>
> diff --git a/builtin-tag.c b/builtin-tag.c
> index 01e7374..8ff9d03 100644
> --- a/builtin-tag.c
> +++ b/builtin-tag.c
> @@ -16,7 +16,7 @@
>  static const char * const git_tag_usage[] = {
>        "git tag [-a|-s|-u <key-id>] [-f] [-m <msg>|-F <file>] <tagname> [<head>]",
>        "git tag -d <tagname>...",
> -       "git tag -l [-n[<num>]] [<pattern>]",
> +       "git tag -l [-n[<num>] -D] [<pattern>]",
>        "git tag -v <tagname>...",
>        NULL
>  };

Hmm, the -D option is independent of -n, so "[-D]". Also, it must be documented.

<snip/>

Wouldn't it make sense to split this patch so the first part adds the
option to filter, even if there are not filters functional, and the
second one adds the date filter?

-- 
Felipe Contreras