From: Kristoffer Haugsbakk Date: Fri, 28 Aug 2026 13:48:13 GMT Subject: Re: [PATCH 3/3] format-patch: learn --[no-]range-diff-notes Message-ID: <9335a35f-e9c0-4e62-812c-e5855c201003@app.fastmail.com> In-Reply-To: On Fri, Aug 28, 2026, at 02:31, Junio C Hamano wrote: > "Kristoffer Haugsbakk" writes: > >>> Hmph, this is a bit too complex for me. When I say >>> >>> $ git format-patch --no-notes --range-diff-notes ... >>> >>> I would expect that individual patches would not get notes, but the >>> range-diff will include them in the comparison. But if >>> --range-diff-notes just falls back to default (i.e., inherit what >>> patches use), would I see the notes used in the range-diff? >> >> You will not get patch notes and not get >> range diff notes. That --range-diff-notes >> told it to use the patch notes which you >> just turned off/emptied the list. >> >> Code-wise, the list of notes is cleared so you >> you would have to change the --notes implementation >> if you want to keep a sort of shadow list >> of not-patch-notes-but-RD-notes. > > IOW, the design of how these options interact does not support the > usecase I gave? Correct as far as I understand the use case. > >> And another problem, or fact, is that format-patch >> does not show notes by default. So what should >> --RD-notes show? The default notes? > > I do not know. My preference actually is not to introuce a new > option whose interaction with the existing --notes option cannot be > defined in simple terms. Let's drop this topic then. sent from mobile