From: Derrick Stolee Date: Mon, 06 Apr 2020 12:49:34 GMT Subject: Re: [PATCH 09/15] job-runner: load repos from config by default Message-ID: <92e8290c-a8ff-fc4f-1da3-1ee8c2636bce@gmail.com> In-Reply-To: <29e32e80-a546-6e43-8d03-bafca03681ec@gmail.com> On 4/5/2020 11:18 AM, Phillip Wood wrote: > Hi Stolee > > On 03/04/2020 21:48, Derrick Stolee via GitGitGadget wrote: >>   +    config_repos = git_config_get_value_multi("job.repo"); > > Does this really re-read the config files as the commit message suggests or just return the cached values? Perhaps the runner could exec itself with a --run-jobs option to actually run the jobs so that it sees any updated config values. You're right, I need to double-check that. I'm guessing that you are right and it uses the cached values. This should use the run_command() pattern to ensure the config is as new as possible. Thanks, -Stolee