From: Derrick Stolee Date: Mon, 19 Sep 2022 15:08:17 GMT Subject: Re: [PATCH] Documentation: add ReviewingGuidelines Message-ID: <925b1e37-17aa-9168-9246-ac48e043c0d4@github.com> In-Reply-To: <5685773e-db83-6b92-ff42-0d51e6e6a22e@github.com> On 9/13/2022 7:11 PM, Victoria Dye wrote: > Junio C Hamano wrote: >> "Victoria Dye via GitGitGadget" writes: >> >>> From: Victoria Dye >>> >>> Add a reviewing guidelines document including advice and common terminology >>> used in Git mailing list reviews. The document is included in the >>> 'TECH_DOCS' list in order to include it in Git's published documentation. >>> >>> Helped-by: Johannes Schindelin >>> Helped-by: Derrick Stolee >>> Signed-off-by: Victoria Dye >>> --- >> >> I've commented on the text but haven't seen anybody else reviewing. >> No interest? Everybody silently happy? > > My guess is that there aren't as many eyes on this as there might typically > be because of Git Merge. Yes, Git Merge took all of my attention in the past week, so I couldn't chime in at all here. My "Helped-by" includes some small suggestions from me, but mostly I fully support having this kind of document. This one is an excellent base to start from for future augmentation as we discover ideas that could avoid sticky situations. I particularly like how this document assumes good intent from all parties, but recommends over-communicating to be sure that intent is clear to everyone. Thanks, -Stolee