From: Derrick Stolee Date: Tue, 10 Feb 2026 18:12:00 GMT Subject: Re: [PATCH 3/5] config: allow format_config() to filter Message-ID: <91fb7d01-cc6a-47b5-a23a-45b0fb31134a@gmail.com> In-Reply-To: On 2/10/2026 12:04 AM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> From: Derrick Stolee >> >> The format_config() method in builtin/config.c currently only uses >> git_config_*() methods for parsing. This allows parsing errors to result >> in die() messages appropriate with keys in the error message. >> >> In a future change we will want to use format_config() within 'git >> config list' to help format the output, including when --type= >> arguments are provided. When the parsing fails in that case, that >> key-value pair should be omitted instead of causing a failure across the >> entire command. >> >> This change is formatted in such a way that the if/else-if structure >> allows the default die_on_error version to appear first and then be >> followed by the gentle parsing mode immediately afterwards. >> >> The only callers right now have die_on_parse set to 1. > > Certainly you meant die-on-parse-errors, not unconditionally die > when asked to parse ;-). > > I wonder if a "bool gently" like everybody else takes would be > easier to understand by more developers and readers, though. 'gently' makes a lot more sense. >> + if (opts->type == TYPE_INT && die_on_parse) { >> strbuf_addf(buf, "%"PRId64, >> git_config_int64(key_, value_ ? value_ : "", kvi)); >> + } else if (opts->type == TYPE_INT) { >> + int64_t v; >> + int ret = git_parse_int64(value_, &v); >> + >> + if (ret) >> + return -1; >> + >> + strbuf_addf(buf, "%"PRId64, v); >> + } > > So, this follows the typical layout that was described in the > proposed log message. I wonder if it is too much to break the set > of helper functions further down so that this part of the caller can > say something like: > > switch (opts->type) { > case TYPE_INT: > format_config_int(buf, key_, value_, kvi, gently); > break; > > and similar case arms for other types? I had a similar feeling that such a refactor would be necessary. I didn't want to go through that careful work if it wasn't justified by positive reactions to the RFC. Thanks for calling it out, and I'll definitely put in that effort if we find this worth a v2. Thanks, -Stolee