From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mon, 03 Jun 2019 21:04:27 GMT
Subject: Re: [PATCH v1 3/5] list-objects-filter: implement composite filters
Message-ID: <91f8f9aa-e427-1b24-db9d-fad53e9e19c5@jeffhostetler.com>
In-Reply-To: <20190531205305.GD4641@comcast.net>



On 5/31/2019 4:53 PM, Matthew DeVore wrote:
> On Thu, May 30, 2019 at 10:01:47AM -0400, Jeff Hostetler wrote:
>> BTW, I don't think I've seen this mentioned anywhere and I don't
>> remember if this got into the code or not.  But we discussed having
>> a repo-local config setting to remember the filter-spec used by the
>> partial clone that would be inherited by a subsequent (partial) fetch.
>> Or would be set by the first partial fetch following a normal clone.
>> Having a single composite filter spec would help with this.
> 
> Isn't that what the partial_clone_get_default_filter_spec function is for? I
> forgot about that. Perhaps with Emily's suggestion to use parsing functions in
> the C library and the other cleanups I've applied since the first roll-up, using
> the URL encoding will seem nicer. Let me try that...
> 

Yes, thanks.  That's what I was thinking about.

Jeff