From: rae l <crquan@gmail.com>
Date: Tue, 18 Nov 2008 00:56:12 GMT
Subject: Re: [PATCH 3/3] git-remote: simplifying get_one_entry
Message-ID: <91b13c310811171656v54363993rfe0f149e7d1da0b0@mail.gmail.com>
In-Reply-To: <7vabbywb75.fsf@gitster.siamese.dyndns.org>

On Tue, Nov 18, 2008 at 12:48 AM, Junio C Hamano <gitster@pobox.com> wrote:
> crquan@gmail.com writes:
>
>> From: Cheng Renquan <crquan@gmail.com>
>>
>> The loop for remote->url_nr is really useless, set to the last one
>> directly is better.
>
> Is it really useless?  Be more descriptive.
>
>> -     if (remote->url_nr > 0) {
>> -             int i;
>> -
>> -             for (i = 0; i < remote->url_nr; i++)
>> -                     string_list_append(remote->name, list)->util = (void *)remote->url[i];
>> -     } else
>> -             string_list_append(remote->name, list)->util = NULL;
>> +     string_list_append(remote->name, list)->util =
>> +             remote->url_nr > 0
>> +             ? (void *)remote->url[remote->url_nr-1] : NULL;
>
> When you have more than one URL associated with the remote (this makes
> sense only for pushing), the current code adds that many string_list_item
> to the list, each holding the URL.  "git remote -v" shows all of them.
>
> Your change instead creates only one string_list_item and hold the last
> URL.  Doesn't it make show_all() to show only one URL for the remote?
Sorry, this patch is totally wrong, I will regenerate the other two and resend.

Thanks for your patience.

-- 
Cheng Renquan, Shenzhen, China
Steven Wright  - "Cross country skiing is great if you live in a small country."