From: Johannes Sixt Date: Sun, 24 Dec 2017 11:51:12 GMT Subject: Re: [PATCH 6/6] wildmatch test: create & test files on disk in addition to in-memory Message-ID: <9191ea80-2faf-b0d1-35c8-6e28e7b8324e@kdbg.org> In-Reply-To: <874logs7vi.fsf@evledraar.gmail.com> Am 24.12.2017 um 12:06 schrieb Ævar Arnfjörð Bjarmason: > On Sun, Dec 24 2017, Johannes Sixt jotted: >> Am 23.12.2017 um 22:30 schrieb Ævar Arnfjörð Bjarmason: >>> + printf '%s' '$text' >expect && >> >> There are no single-quotes in any $text instances, right? > > There's not, but maybe we should be more careful here and use here-docs. Unless it is essential to test the single-quote case, we need not complicate the code. I just wanted to rise awareness. If a problematic test case is introduced, it will be noticed soon enough. It's not that we deal with unknown input here. -- Hannes