From: Brian Gernhardt <benji@silverinsanity.com>
Date: Thu, 02 Oct 2008 20:17:46 GMT
Subject: Re: [PATCH] format-patch: autonumber by default
Message-ID: <91634D16-B28A-4458-97A9-C469B5AF4E5D@silverinsanity.com>
In-Reply-To: <1222970291-5337-1-git-send-email-giuseppe.bilotta@gmail.com>


On Oct 2, 2008, at 1:58 PM, Giuseppe Bilotta wrote:

> diff --git a/builtin-log.c b/builtin-log.c
> index fc5e4da..5187dc2 100644
> --- a/builtin-log.c
> +++ b/builtin-log.c
> @@ -426,7 +426,7 @@ static int istitlechar(char c)
>
> static const char *fmt_patch_suffix = ".patch";
> static int numbered = 0;
> -static int auto_number = 0;
> +static int auto_number = 1;
>
> static char **extra_hdr;
> static int extra_hdr_nr;
> @@ -484,6 +484,10 @@ static int git_format_config(const char *var,  
> const char *value, void *cb)
>  			auto_number = 1;
>  			return 0;
>  		}
> +		if (value && !strcasecmp(value, "noauto")) {
> +			auto_number = 0;
> +			return 0;
> +		}
>  		numbered = git_config_bool(var, value);
>  		return 0;
>  	}

format.numbered is a tri-state config option right now: {yes, no,  
auto}.  With this patch, if you add "[format] numbered = false" into  
your config, you still get auto-numbering.

A better way to do this might be to default both numbered and  
auto_number to true and only use auto_number is numbered is true.  Or  
turn off auto-numbering when numbering is turned off just below your  
hunk.

Either way, "noauto" is a bad idea.  It's spelled "no" or "false".

~~ Brian Gernhardt