From: Derrick Stolee <stolee@gmail.com>
Date: Tue, 06 Oct 2026 14:38:10 GMT
Subject: ds/trace2-tolerate-failed-timestamp (was Re: What's cooking in git.git (Oct 2026, #02))
Message-ID: <91339226-5026-4618-a642-eb2267038f74@gmail.com>
In-Reply-To: <xmqqwlrviv8g.fsf@gitster.g>

On 10/5/2026 7:27 PM, Junio C Hamano wrote:

> * ds/trace2-tolerate-failed-timestamp (2026-08-31) 7 commits
>  - trace2: remove use of xcalloc()
>  - trace2: remove use of ALLOC_GROW()
>  - trace2: remove use of xstrfmt()
>  - trace2: remove use of ALLOC_ARRAY()
>  - trace2: remove use of xstrdup()
>  - trace2: tolerate failed timestamp formatting
>  - banned-die: create header for banning of functions
> 
>  Functions like `xstrfmt()` and `xcalloc()` have been banned from use
>  in the trace2 API codebase to prevent calls to `die()` which lead to
>  unwanted process exits and recursion when memory allocation fails.
> 
>  Needs review.
>  source: <pull.2178.v3.git.1788197143.gitgitgadget@gmail.com>

This can be evicted. It's not delivering much value for the
complexity that it adds, and having banned-die.h present in the
repo may suggest stronger protections than it really promises.

Thanks,
-Stolee