From: Derrick Stolee <stolee@gmail.com>
Date: Thu, 18 Oct 2018 12:59:32 GMT
Subject: Re: [PATCH 1/3] t6501: use --quiet when testing gc stderr
Message-ID: <90d051a5-8c02-518d-01a7-16746061e6b9@gmail.com>
In-Reply-To: <xmqq1s8nvndm.fsf@gitster-ct.c.googlers.com>



On 10/18/2018 1:23 AM, Junio C Hamano wrote:
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Derrick Stolee <dstolee@microsoft.com>
>>
>> The test script t6501-freshen-objects.sh has some tests that care
>> if 'git gc' has any output to stderr. This is intended to say that
>> no warnings occurred related to broken links. However, when we
>> have operations that output progress (like writing the commit-graph)
>> this causes the test to fail.
> I see that the descriptor #2 is redirected into a regular file.  Why
> should we be writing the progress indicator in that case in the
> first place?  Shoudln't we be doing the usual "are we showing this
> to an interactive terminal?" test?

This code from builtin/gc.c makes it look like we are doing that:

         if (gc_write_commit_graph)
                 write_commit_graph_reachable(get_object_directory(), 0,
                                              !quiet && !daemonized);

But really, daemonized is only for when running in the background.

Do you have an example of a builtin that checks this interactive 
terminal behavior?

Thanks,
-Stolee