From: Phillip Wood <phillip.wood123@gmail.com>
Date: Fri, 07 Nov 2025 15:48:30 GMT
Subject: Re: [PATCH v7 0/3] replay: make atomic ref updates the default
Message-ID: <906fba13-fc84-411c-a43f-baaa2b90ed95@gmail.com>
In-Reply-To: <20251105191650.89975-1-siddharthasthana31@gmail.com>

Hi Siddharth

On 05/11/2025 19:15, Siddharth Asthana wrote:

>      @@ builtin/replay.c: int cmd_replay(int argc,
>        	determine_replay_mode(repo, &revs.cmdline, onto_name, &advance_name,
>        			      &onto, &update_refs);
>        
>      ++	/* Build reflog message */
>      ++	if (advance_name_opt)
>      ++		strbuf_addf(&reflog_msg, "replay --advance %s", advance_name_opt);

This appends the name of the branch being advanced, rather than what's 
being picked. As this message is written to the reflog of the branch 
that's being advanced adding the branch name to the message is kind of 
redundant but we can always change this later when we have more 
experience with "--ref-action"

>      ++	else
>      ++		strbuf_addf(&reflog_msg, "replay --onto %s",
>      ++			    oid_to_hex(&onto->object.oid));

This looks good.

Thanks for working on this, I think this is probably ready to me merged.

Phillip