From: Derrick Stolee <stolee@gmail.com>
Date: Mon, 03 Aug 2020 12:39:05 GMT
Subject: Re: [PATCH] midx: use buffered I/O to talk to pack-objects
Message-ID: <90541678-f412-89a1-2ee0-4cae30e26551@gmail.com>
In-Reply-To: <c5920e08-b7dd-e870-f99e-225d0aafc663@web.de>

On 8/2/2020 10:38 AM, René Scharfe wrote:
> Like f0bca72dc77 (send-pack: use buffered I/O to talk to pack-objects,
> 2016-06-08), significantly reduce the number of system calls and
> simplify the code for sending object IDs to pack-objects by using
> stdio's buffering and handling errors after the loop.

Good find. Thanks for doing this important cleanup.

Outside of Chris's other feedback, this looks like an obviously
correct transformation.

Thanks,
-Stolee