From: Tarmigan <tarmigan+git@gmail.com>
Date: Mon, 28 Dec 2009 04:07:26 GMT
Subject: Re: [PATCH 2/2] Smart-http: check if repository is OK to export before serving it
Message-ID: <905315640912272007i8b4904dv2b93879789b453fb@mail.gmail.com>
In-Reply-To: <20091227211033.GB609@spearce.org>

On Sun, Dec 27, 2009 at 4:10 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> Tarmigan Casebolt <tarmigan+git@gmail.com> wrote:
>> Similar to how git-daemon checks whether a repository is OK to be
>> exported, smart-http should also check.  This check can be satisfied
>> in two different ways: the environmental variable GIT_HTTP_EXPORT_ALL
>> may be set to export all repositories, or the individual repository
>> may have the file git-daemon-export-ok.
>>
>> Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
> I really think this and 1/2 should be squashed together, in which
> case you can apply my ACK to the entire thing.

Great, thanks for the ACK.

Squashing sounds good to me, I just split it so someone could verify
that the tests fail first if they want.

I've been thinking that the not_found() to a forbidden() instead.
Thoughts?  I'll send out a unified patch with that change in a reply.

Thanks,
Tarmigan