From: Jakub Narebski <jnareb@gmail.com>
Date: Thu, 17 Aug 2006 10:08:06 GMT
Subject: Re: [PATCH 4/7] gitweb: Expand href() function to use key as param name for no mapping
Message-ID: <8fe92b430608170308n42942798xf50f814052bee1c4@mail.gmail.com>
In-Reply-To: <7v8xlnsmyl.fsf@assigned-by-dhcp.cox.net>

On 8/17/06, Junio C Hamano <junkio@cox.net> wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > Expand href() function to use key name of params hash as a query param
> > name, if there is no mapping for given key name.
> >
> > It is now safer to use href(); no errors, but links might not work
> > correctly if caller didn't provide correct arguments.
> >
> > Future proofing.
>
> I think that is not a "future proofing" but is "sweeping mess
> under the rug" ;-).
At least leave 'if (exists $mapping{$_})' even if you remove the 'else' part.

[...]
> Obviously unrelated and probably unplanned revert of [2/7] in
> the series, so will not apply.
Ooops, sorry, I haven't noticed this... Very unplanned.

-- 
Jakub Narebski