From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Wed, 29 Mar 2017 10:44:13 GMT
Subject: Re: [PATCH v4 2/5] dir_iterator: iterate over dir after its contents
Message-ID: <8eeadbe1-6a28-cee7-5dcb-5d408aac8925@alum.mit.edu>
In-Reply-To: <7a665631-da6a-4b9f-b9e7-750f2504eccd@alum.mit.edu>

On 03/29/2017 11:56 AM, Michael Haggerty wrote:
> On 03/29/2017 02:32 AM, Daniel Ferreira wrote:
>> [...]
> [...]
> The disagreement is not a surprise, because there isn't a corresponding
> coding error in the code below that returns the directory itself in a
> post-order iteration. The net result appears to be that there is no
> recursion at all into subdirectories when `DIR_ITERATOR_DEPTH_FIRST` is
> set. So due to this bug, we get neither a correct post-order iteration
> nor a correct pre-order iteration with the new option.

Correction: the second-to-last sentence should read "there is no
recursion at all into subdirectories when `DIR_ITERATOR_DEPTH_FIRST` is
*NOT* set.

Michael