From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 18 May 2015 15:26:18 GMT
Subject: Re: [PATCH v2] pull: handle --log=<n>
Message-ID: <8db56697772d5d5a4a01268e47db2bfe@www.dscho.org>
In-Reply-To: <CACRoPnQKge+3gCnO79yTZHxyPE=XgCONApWPF7Ue7DSxr0E7Og@mail.gmail.com>

Hi Paul,

On 2015-05-18 17:15, Paul Tan wrote:
> Just a mental note to myself,
> 
> On Mon, May 18, 2015 at 9:39 PM, Paul Tan <pyokagan@gmail.com> wrote:
>> diff --git a/t/t5524-pull-msg.sh b/t/t5524-pull-msg.sh
>> index 8cccecc..eebb8c9 100755
>> --- a/t/t5524-pull-msg.sh
>> +++ b/t/t5524-pull-msg.sh
>> @@ -17,6 +17,9 @@ test_expect_success setup '
>>                 git commit -m "add bfile"
>>         ) &&
>>         test_tick && test_tick &&
>> +       echo "second" >afile &&
>> +       git add afile &&
>> +       git commit -m "second commit" &&
>>         echo "original $dollar" >afile &&
>>         git add afile &&
>>         git commit -m "do not clobber $dollar signs"
>> @@ -32,4 +35,18 @@ test_expect_success pull '
>>  )
>>  '
>>
>> +test_expect_failure '--log=1 limits shortlog length' '
> 
> Ugh ><
> 
> s/test_expect_failure/test_expect_success/

Heh, I missed that one myself.

> Will respond to the other reviews tomorrow (it's bedtime in SGT).

That was quite some stuff you sent to the list, indeed. Good work!

Ciao,
Dscho