From: Derrick Stolee <stolee@gmail.com>
Date: Thu, 09 Jul 2020 11:14:41 GMT
Subject: Re: [PATCH 09/21] maintenance: add commit-graph task
Message-ID: <8dacf017-c445-578c-c82c-f6d6f93469c9@gmail.com>
In-Reply-To: <20200709022942.39848-1-jonathantanmy@google.com>

On 7/8/2020 10:29 PM, Jonathan Tan wrote:
>> +static int run_write_commit_graph(struct repository *r)
>> +{
>> +	int result;
>> +	struct argv_array cmd = ARGV_ARRAY_INIT;
>> +
>> +	argv_array_pushl(&cmd, "-C", r->worktree,
>> +			 "commit-graph", "write",
>> +			 "--split", "--reachable",
>> +			 NULL);
> 
> As mentioned in my reply to an earlier patch (sent a few minutes ago),
> this won't work if there are environment variables like GIT_DIR present.

Do we not pass GIT_DIR to the subcommand? Or does using "-C" override
the GIT_DIR?

Thanks,
-Stolee