From: Jeff Hostetler <git@jeffhostetler.com>
Date: Thu, 24 Mar 2022 20:45:53 GMT
Subject: Re: [PATCH v8 21/30] t7527: create test for fsmonitor--daemon
Message-ID: <8c9e30be-5138-ecfe-5c37-4f91b4d3002f@jeffhostetler.com>
In-Reply-To: <xmqqils3gort.fsf@gitster.g>



On 3/24/22 2:59 PM, Junio C Hamano wrote:
> "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> 
> I hadn't signed off on this one yet ;-)

Sorry, I started a recent rebase based upon your version
of the commits and it had your signoff in it.

> 
>> +is_value () {
>> +	test -n "$1" && test "${1::1}" != "-"
>> +}
> 
> ${var:ofs:len} is a bash-ism.  If you run this test under /bin/dash
> instead of /bin/dash, you'll likely see it fail.
[...]

I'll simplify the function as you suggested and send a V9 in
the morning after GGG's CI finishes.

Thanks
Jeff