From: Patryk Obara Date: Fri, 26 Jan 2018 17:44:01 GMT Subject: Re: [PATCH] setup: recognise extensions.objectFormat Message-ID: <8c6b33fc-38e8-f617-0466-c282b3e2d61d@gmail.com> In-Reply-To: On 26/01/2018 15:41, Johannes Schindelin wrote: > On Thu, 25 Jan 2018, Duy Nguyen wrote: >> >> This config is so sensitive I wonder if we should forbid changing it >> via git-config. You can't simply change this and expect anything to >> work anyway. > > I don't think it makes sense to forbid `git config` from changing these > values, as it is all-too-easy to change them via `git config -e` *anyway*. > And we already have the repositoryFormat precedent with the exact same > issue. > > In my opinion, it would only complicate the code, for very little (if at > all noticable) benefit. That's my sentiment as well, but some measure of user protection might be necessary. I was thinking about doing a sanity check: when objectFormat is set, re-hash N (randomly selected?) objects, where N is sufficient to get 3-sigma confidence. This might be necessary to prevent object store corruption e.g. when objectFormat is set in repo, that is cloned with reference from repo without extension. -- | ← Ceci n'est pas une pipe Patryk Obara