From: Lars Hjemli Date: Mon, 18 Feb 2008 14:04:27 GMT Subject: Re: [PATCH 2/5] Add platform-independent .git "symlink" Message-ID: <8c5c35580802180604w13e28cfdqce7aaad6676346e6@mail.gmail.com> In-Reply-To: On Feb 18, 2008 2:35 PM, Johannes Schindelin wrote: > Hi, > > On Mon, 18 Feb 2008, Lars Hjemli wrote: > > > On Feb 18, 2008 1:34 PM, Johannes Schindelin wrote: > > > > > > [* snip *] > > > > > > So maybe we can just scratch all that, and I agree that an invalid > > > .git file means "no repository" (as opposed to "no valid repository"). > > > > > > In that case, you might want to test for that, too... > > > > I think I do, did you find a loophole in the testing? > > I meant writing a readable, but invalid .git file. Then testing that Git > die()s with the correct message. Ah, sorry for being slow, that's an excellent suggestion. I'll update the test-script and resend 2/5. -- larsh