From: Lars Hjemli <lh@elementstorage.no>
Date: Sun, 14 Oct 2007 22:40:22 GMT
Subject: Re: [PATCH 5/7] Bisect: factorise some logging into "bisect_write".
Message-ID: <8c5c35580710141540j6f93a08j2179c5c394bfacd5@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.64.0710141706440.25221@racer.site>

On 10/14/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> On Sun, 14 Oct 2007, Christian Couder wrote:
> > diff --git a/git-bisect.sh b/git-bisect.sh
> > index 847250c..e12125f 100755
> > --- a/git-bisect.sh
> > +++ b/git-bisect.sh
> > @@ -132,6 +131,7 @@ bisect_write() {
> >       esac
> >       echo "$rev" >"$GIT_DIR/refs/bisect/$tag"
> >       echo "# $state: "$(git show-branch $rev) >>"$GIT_DIR/BISECT_LOG"
> > +     test -z "$nolog" && echo "git-bisect $state $rev" >>"$GIT_DIR/BISECT_LOG"
> >  }
>
> Isn't a nolog="$3" missing from bisect_write()?

Good catch, I've amended the commit and replaced q/cc/bisect-dunno
with this series.

--
larsh