From: Lars Hjemli <hjemli@gmail.com>
Date: Sun, 13 May 2007 16:52:16 GMT
Subject: Re: suggestions for gitweb
Message-ID: <8c5c35580705130952r7c0e353dr9cf20aed61bdd463@mail.gmail.com>
In-Reply-To: <f25mic$1b1$2@sea.gmane.org>

On 5/13/07, Jakub Narebski <jnareb@gmail.com> wrote:
> Aaron Gray wrote:
>
> >>> * the history/log pages could contain some statistics for the commits
> >>>   like the number of files changed and lines added/removed
> >>
> >> Probably.
> >>
> >> The three last items should be relatively easy, if somebody is
> >> interested.  Pasky, Jakub, what do you think?
> >
> > I would like to see lines of code and file sizes too.
>
> Diff statistics for difftree / whatchanged, or diff shortstat is a bit
> costly, as it needs to generate and examine diff, and not only compare
> trees. Besides --numstat doesn't support renames well now, but that
> might not be an obstacle.
>
> Lines of code and file sizes: file size needs additional invocation
> per each file for gitweb; it would be easier for cgit. Costly! Counting
> LOC is even more costly

I've implemented number of files/lines changed in cgit's log view and
pushed it to http://hjemli.net/git/

It does consume some cpu (especially on the linux-2.6 repo), but it's
not terribly bad (and the caching helps out). But I felt like changing
the number of commits per page to 50, so I added a knob for this in
the config file while at it.

I'll try to get a proper diffstat on the commit page + file history
via tree view next (filesize has always been part of cgits tree view
btw).

--
larsh