From: Lars Hjemli <hjemli@gmail.com>
Date: Sat, 25 Nov 2006 10:52:48 GMT
Subject: Re: [RFC] Teach git-branch howto rename a branch
Message-ID: <8c5c35580611250252r50539e4ere98bb38c7b8c9c9@mail.gmail.com>
In-Reply-To: <7vd57b3jc2.fsf@assigned-by-dhcp.cox.net>

On 11/25/06, Junio C Hamano <junkio@cox.net> wrote:
> "Lars Hjemli" <lh@elementstorage.no> writes:
>
> > Is it ok to put
> >
> > static int log_ref_write(struct ref_lock *lock,
> >       const unsigned char *sha1, const char *msg)
> >
> > into refs.h?
>
> I think a cleaner implementation that does not have such a
> layering violation would involve defining rename_refs()
> interface in refs.c, next to the delete_ref() that exists there.

Yes, that looks a lot nicer. I'll give it a try.

--