From: Phillip Wood Date: Mon, 11 Dec 2017 18:53:53 GMT Subject: Re: [PATCH v5 7/9] sequencer: load commit related config Message-ID: <8bf28a43-fe0d-67c9-0a47-3e022a406ad7@talktalk.net> In-Reply-To: <20171211141330.23566-8-phillip.wood@talktalk.net> On 11/12/17 14:13, Phillip Wood wrote: > From: Phillip Wood > > Load default values for message cleanup, gpg signing of commits and > basic diff configuration in preparation for committing without forking > 'git commit'. Note that we interpret commit.cleanup=scissors to mean > COMMIT_MSG_CLEANUP_SPACE to be consistent with 'git commit'. > > The sequencer should probably have been calling > git_diff_basic_config() before as it creates a patch when there are > conflicts. The shell version uses 'diff-index' to create the patch so s/diff-index/diff-tree/