From: Prarit Bhargava <prarit@redhat.com>
Date: Fri, 25 Oct 2019 10:56:40 GMT
Subject: Re: [PATCH v2] pretty: add "%aL"|"%al|%cL|%cl" option to output local-part of email addresses
Message-ID: <8baf0152-e38a-eaad-b181-72e2d3d2f00d@redhat.com>
In-Reply-To: <xmqqwoctcszm.fsf@gitster-ct.c.googlers.com>



On 10/25/19 1:08 AM, Junio C Hamano wrote:
> Prarit Bhargava <prarit@redhat.com> writes:
> 
>> It can't harm anything to have braces but if the preferred git coding style is
>> to only use them when necessary I will remove them.
> 
> It harms readability.  Don't try to be different just for the sake
> of being different, especially when you think "it can't harm
> anything" aka "there is no strong reason to do so (or not to)".
> Instead, help others by making sure that their eyes do not have to
> get distracted for such meaningless differences from existing parts
> of the system.

Ha :)  I did pull them for v3 after doing a search.  I didn't reply properly and
should have said "I'll do a search".  Admittedly I'm concerned in a few spots in
the code where it *seems* like something could go wrong if the code is changed.
But nothing worth patching over.

P.

> 
> Thanks.
>