From: Johannes Sixt <j6t@kdbg.org>
Date: Mon, 21 Nov 2016 18:58:41 GMT
Subject: Re: [PATCH 3/3] rebase -i: handle core.commentChar=auto
Message-ID: <8b783f3d-8fda-b5cb-239f-895b10a22a73@kdbg.org>
In-Reply-To: <xmqq37ikk762.fsf@gitster.mtv.corp.google.com>

Am 21.11.2016 um 19:40 schrieb Junio C Hamano:
> Johannes Sixt <j6t@kdbg.org> writes:
>> It could be written without forking a process:
>>
>> 	comment_char=${comment_char%${comment_char#?}}
>>
>> (aka "remove from the end what remains after removing the first character")
>
> Hopefully nobody would include any glob metacharacters in there,
> e.g. "core.commentchar='=*'", which would break that?

Heh. I tested a few variations, but not this one. Make it

  	comment_char=${comment_char%"${comment_char#?}"}

;)

-- Hannes