From: Phillip Wood <phillip.wood123@gmail.com>
Date: Fri, 23 Oct 2026 15:09:59 GMT
Subject: Re: [PATCH v5 1/1] archive-zip: refactor 'path too long' error message to use Q_()
Message-ID: <8b75a831-f8b7-4e8d-9dbf-0f7fca5e7bc7@gmail.com>
In-Reply-To: <20261023120358.8061-2-kerylefondji7@gmail.com>

Hi Keryle

On 23/10/2026 13:03, kerylefondji7@gmail.com wrote:
> > diff --git a/archive-zip.c b/archive-zip.c
> index 5ab3ba786f..160efd878f 100644
> --- a/archive-zip.c
> +++ b/archive-zip.c
> @@ -328,10 +328,10 @@ static int write_zip_entry(struct archiver_args *args,
>   	}
>   >   	if (pathlen > 0xffff) {
> -	 return error(Q_("path too long (%d char, SHA1: %s): %s",
> -	  "path too long (%d chars, SHA1: %s): %s",
> -	 pathlen),
> -		(int)pathlen, oid_to_hex(oid), path);
> +		return error(Q_("path too long (%d char, SHA1: %s): %s",
> +				"path too long (%d chars, SHA1: %s): %s",
> +				pathlen),
> +			     (int)pathlen, oid_to_hex(oid), path);

The indentation looks good, but this does not apply to master. When you get feedback about a patch, you should send an amended patch that applies to master, not a fix that applies on top of the patch you previously sent. If a patch series contains more than one patch, you can use "git rebase -i" to prepare the new version. If there is a single patch like this series you can use "git commit --amend".

Thanks

Phillip