From: kristofferhaugsbakk@fastmail.com Date: Wed, 17 Sep 2025 20:24:11 GMT Subject: [PATCH v6 1/9] Makefile: don’t add whatchanged after it has been removed Message-ID: <8b34e.1758139856.short.code@khaugsbakk.name> In-Reply-To: From: Kristoffer Haugsbakk 07572f220a8 (whatchanged: remove when built with WITH_BREAKING_CHANGES, 2025-05-12) set up the removal of git-whatchanged(1) when `WITH_BREAKING_CHANGES` is active. Part of that work was removing it from `commands` in `git.c`. But the Makefile still lists it as a builtin. That leaves it in the limbo of being linked but not being callable; you get the generic error about not being able to call it as a *builtin*: $ git whatchanged fatal: cannot handle whatchanged as a builtin instead of the expected: $ git whatchanged git: 'whatchanged' is not a git command. See 'git --help'. Based-on-patch-by: Jeff King Signed-off-by: Kristoffer Haugsbakk --- Notes (series): v6 (new): Link/Source: https://lore.kernel.org/git/cover.1757446619.git.code@khaugsbakk.name/T/#mfa023b1c1626df68d25714a5981d8662a66199dc Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index e11340c1ae7..9311da5bb15 100644 --- a/Makefile +++ b/Makefile @@ -883,7 +883,9 @@ BUILT_INS += git-stage$X BUILT_INS += git-status$X BUILT_INS += git-switch$X BUILT_INS += git-version$X +ifndef WITH_BREAKING_CHANGES BUILT_INS += git-whatchanged$X +endif # what 'all' will build but not install in gitexecdir OTHER_PROGRAMS += git$X -- 2.51.0.274.gdcb64e51a0f