From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Fri, 21 Apr 2017 06:42:16 GMT
Subject: Re: [PATCH] refs.h: rename submodule arguments to submodule_path
Message-ID: <8b2ef70c-4064-f726-8752-5bb0a898ee7a@alum.mit.edu>
In-Reply-To: <cb1dd8b6-3357-57ff-650d-c55a7eb38d34@alum.mit.edu>

On 04/21/2017 08:32 AM, Michael Haggerty wrote:
> [...]
> I've CCed Duy because I don't know whether he has more plans regarding
> submodule references [...] get rid of the
> `for_each_ref_submodule()` family of functions entirely.
> 
> So perhaps the code that this patch touches won't be around long anyway.

Oh yeah, he has done exactly that in his nd/prune-in-worktree patch
series. (I knew I'd seen that somewhere...)

So it seems that the argument renaming has mostly been overtaken by
events, though even after Duy's patch series there are a few `const char
*submodule` arguments that could be renamed.

Michael