From: Santi Béjar Date: Wed, 07 May 2008 16:32:24 GMT Subject: Re: [PATCHv4 4/4] user.warnautomatic: add config to control if the committer ident is shown Message-ID: <8aa486160805070932w44edf4b0j3b712ec22c10fe7d@mail.gmail.com> In-Reply-To: <7v8wymdred.fsf@gitster.siamese.dyndns.org> On Wed, May 7, 2008 at 6:12 PM, Junio C Hamano wrote: > Santi Béjar writes: > > > Signed-off-by: Santi Béjar > > By setting this new variable the user can squelch undesired noise the > previous change introduces, but the user can just set user.name and > user.email to desired values to squelch it anyway. Or the user prefers the automatic ident. > > So either this new variable is superfluous, or the previous change is too > susceptible to produce false positives that need squelching with such a > variable, or both. In any case, not a very good sign. For me it is superfluous, as I prefer to see what is the committer ident when it is generated. I even said I prefer just showing the automatic ident. I sent it in case it was decided it was worth. Santi