From: Santi Béjar <sbejar@gmail.com>
Date: Thu, 01 May 2008 08:34:44 GMT
Subject: Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent
Message-ID: <8aa486160805010134l4746f9afhec546a9d49fd7a6d@mail.gmail.com>
In-Reply-To: <20080430192639.GC30344@sigill.intra.peff.net>

On Wed, Apr 30, 2008 at 9:26 PM, Jeff King <peff@peff.net> wrote:
> On Wed, Apr 30, 2008 at 09:23:43PM +0200, Santi Béjar wrote:
>
>  > >  I like the idea in general, but the implementation could be refined.
>  > >  Maybe consider looking at user.name (whether the repo has an ident
>  > >  set)? This is usually done conciously, and the user wont need this
>  > >  reminder.
>  >
>  > Maybe only show the committer ident when both happens:
>  >
>  > 1) the committer ident is different from the parent
>  > 2) the committer ident is set automatically
>
>  Honestly, I think just "2)" is probably fine (where automatically
>  presumably means "from GECOS"). I see what you are trying to accomplish
>  with "1)", but it's so workflow specific as to be useless.

I don't see "1) as workflow specific, it is there to minimize the
number of time it is shown, ie somebody might prefer the automatic
ident, so as long as it does not change it is not shown.

Santi