From: Santi Béjar <sbejar@gmail.com>
Date: Sat, 08 Mar 2008 00:13:18 GMT
Subject: Re: [PATCH] user.default: New config to prevent using the default values for user.*
Message-ID: <8aa486160803071613pdacc88fkabc10f52da56ad5d@mail.gmail.com>
In-Reply-To: <20080307164111.GB4899@steel.home>

On Fri, Mar 7, 2008 at 5:41 PM, Alex Riesen <raa.lkml@gmail.com> wrote:
> Santi Béjar, Thu, Mar 06, 2008 22:45:43 +0100:
>
>
> > On Wed, Mar 5, 2008 at 9:44 PM, Alex Riesen <raa.lkml@gmail.com> wrote:
>  > > Santi Béjar, Wed, Mar 05, 2008 20:18:04 +0100:
>  > >
>  > >  > @@ -171,7 +171,7 @@ static const char au_env[] = "GIT_AUTHOR_NAME";
>  > >  >  static const char co_env[] = "GIT_COMMITTER_NAME";
>  > >  >  static const char *env_hint =
>  > >  >  "\n"
>  > >  > -"*** Your name cannot be determined from your system services (gecos).\n"
>  > >  > +"*** Your name cannot be determined.\n"
>  > >
>  > >  Why not?
>  >
>  > Is this important? Or in another way, is this useful? The important
>  > thing is how you can fix it. But others think otherwise I'll change it
>  > to explain the reason.
>
>  It is precise explanation of what happened. It could be a hint to fix
>  gecos field to someone. It is considered useful not to hide
>  information, even if you have no idea of how useful it is.

I'll wait for others to comment.

>  Others may
>  be smarter than you.

I don't think this is necessary.

Santi