From: Johannes Schindelin via GitGitGadget Date: Sat, 27 Aug 2022 12:44:19 GMT Subject: [PATCH v5 11/16] bisect--helper: calling `bisect_state()` without an argument is a bug Message-ID: <8a0adfe3867157102e75d53ed928603ad634b904.1661604264.git.gitgitgadget@gmail.com> In-Reply-To: From: Johannes Schindelin The `bisect_state()` function is now a purely internal function and must be called with a valid state, everything else is a bug. Signed-off-by: Johannes Schindelin --- builtin/bisect--helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 5cf688c0dac..3f333cfae76 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -997,6 +997,8 @@ static enum bisect_error bisect_state(int argc, const char **argv, struct strbuf buf = STRBUF_INIT; struct oid_array revs = OID_ARRAY_INIT; + if (!argc) + BUG("bisect_state() called without argument"); if (bisect_autostart(prefix)) return BISECT_FAILED; -- gitgitgadget