From: Wincent Colaiuta Date: Sun, 12 Aug 2007 16:57:20 GMT Subject: Re: --exit-code (and --quiet) broken in git-diff? Message-ID: <8C80CB6C-83A5-437D-9360-AC93B73EAA54@wincent.com> In-Reply-To: <46BF04F0.5020304@midwinter.com> El 12/8/2007, a las 15:02, Steven Grimm escribió: > David Kastrup wrote: >> I think I would call that a mistake. However, I don't see that >> fixing >> it would actually be useful: if a pager gets called, this means that >> git-diff might die with SIGPIPE (when the user quits the pager), and >> that in turn has pretty much no meaning. So one really needs to >> redirect the output, anyway. >> > > It does sort of make one wonder, though, if there's much point ever > launching a pager when git-diff is run with --quiet -- it will > never produce any output to page, so running a pager is guaranteed > to always be a waste of cycles. Yes, I thought the same thing when I read in the initial release notes () that the "--quiet" option was explicitly "meant for scripted use", where naturally you don't want or need a pager... turns out I was writing a script, you see, and I wanted to test the commands out manually to be sure they did what I thought they would... But as you say, refactoring this to bypass the pager when "--quiet" is passed may be unpleasantly complicated. Cheers, Wincent