From: Dragan Simic Date: Wed, 11 Oct 2023 06:17:10 GMT Subject: Re: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635 Message-ID: <89c51050c7570439f763f8fc8195aada@manjaro.org> In-Reply-To: On 2023-10-11 07:50, Naomi Ibe wrote: > Okay then, I'll work with these guidelines in mind. Thank you very much If I may notice, avoiding top posting has already been suggested twice, IIRC. I think that various webmails have made top posting popular, and actually forced people a bit to do that through the way their user interfaces were laid out, which made inline replies kind of a dying art, which is really sad to see. It is so much more useful when replies are posted inline, i.e. right below the contents they refer to. > On Tue, Oct 10, 2023 at 11:24 PM Junio C Hamano > wrote: >> >> Naomi Ibe writes: >> >> > Thank you very much! I'd definitely make those changes on my next patch. >> >> [administrivia] do not top post. >> >> > Should I begin work on version 2 or should I still wait for additional >> > input on the version 1? >> >> There is no "rule", but based on observations on how people behave, >> e.g. >> >> * for a small patch like this that can be given a good review in 10 >> minutes or so, those who do not do so within the first 3 days >> will probably not do so. >> >> * once a reasonably thorough review is given, those who haven't >> responded to the patch and do not have much else to say are >> unlikely to respond. >> >> * on the other hand, after such a review is given, those who do not >> agree with the review tend to respond rather quickly, to get >> their voice in before it becomes too late. >> >> I would say it would be good to start working on it right away and >> use a couple of days reviewing it yourself before posting it.