From: Patrick Steinhardt Date: Fri, 11 Oct 2024 05:32:08 GMT Subject: [PATCH 01/21] builtin/ls-remote: plug leaking server options Message-ID: <89b66411354437a1e3a97751f185889dffb84126.1728624670.git.ps@pks.im> In-Reply-To: The server options populated via `OPT_STRING_LIST()` is never cleared, causing a memory leak. Plug it. This leak is exposed by t5702, but plugging it alone does not make the whole test suite pass. Signed-off-by: Patrick Steinhardt --- builtin/ls-remote.c | 1 + 1 file changed, 1 insertion(+) diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c index f723b3bf3bb..f333821b994 100644 --- a/builtin/ls-remote.c +++ b/builtin/ls-remote.c @@ -166,6 +166,7 @@ int cmd_ls_remote(int argc, status = 0; /* we found something */ } + string_list_clear(&server_options, 0); ref_sorting_release(sorting); ref_array_clear(&ref_array); if (transport_disconnect(transport)) -- 2.47.0.dirty