From: Jonathan del Strother <maillist@steelskies.com>
Date: Mon, 15 Oct 2007 14:00:38 GMT
Subject: Re: [PATCH 2/3] Quoting paths in tests
Message-ID: <8977E4C2-2C13-4C52-8FD9-CEEB5AA85B70@steelskies.com>
In-Reply-To: <47136F71.1050107@viscovery.net>

On 15 Oct 2007, at 14:47, Johannes Sixt wrote:

> Jonathan del Strother schrieb:
>> -	svn import -m 'import for git-svn' . $svnrepo >/dev/null &&
>> +	svn import -m 'import for git-svn' . '$svnrepo' >/dev/null &&
>> 	cd .. &&
>> 	rm -rf import &&
>> -	git-svn init $svnrepo"
>> +	git-svn init '$svnrepo'"
>
> I don't see the point in changing an incorrect quoting to a  
> different incorrect quoting that you fix up in a follow-up patch.  
> It's *two* large patches to review instead of just one. I'm stopping  
> the review here.

If we want to support apostrophed paths in tests, I'll flatten 2 & 3  
into a single patch.  I thought I'd make the apostrophe part optional  
since there seemed to be some resistance to having to bother about  
quoting & escaping in tests..