From: Kristoffer Haugsbakk Date: Tue, 16 Jun 2026 20:18:37 GMT Subject: Re: [PATCH 6/6] SubmittingPatches: note that trailer order matters Message-ID: <89776d4e-bc61-475f-a12d-167047ddf23e@app.fastmail.com> In-Reply-To: On Thu, Jun 11, 2026, at 00:30, Junio C Hamano wrote: >>[snip] >> Only capitalize the very first letter of the trailer, i.e. favor >> `Signed-off-by:` over `Signed-Off-By:` and `Acked-by:` over `Acked-By:`. >> >> +Note that these trailers should come before your `Signed-off-by:` >> +trailer. You are signing off to the patch as well as the message. This >> +also makes it clear who added trailers when multiple people have signed >> +off on a patch. > > Perhaps first mention the underlying rule that they are added in the > order that helps us to understand the chronological order of events. > That would avoid giving a wrong impression that the nature of each > trailer keys determine the order of these lines. You’re right. It’s best to lead with the time-based order. That naturally leads into the implication that we can easily read what trailers that any given person added. I’ve seen discussions in the past about whether trailers ought to be sorted by *kind*, and maybe if first e.g. you should first have Tested-by, then Reviewed-by, then Signed-off-by... best to not give such an impression by accident. Thanks.