From: Thomas Ackermann <th.acker@arcor.de>
Date: Sun, 25 Aug 2013 09:13:11 GMT
Subject: Aw: Re: [PATCH 05/13] Fix some typos
Message-ID: <892787868.481320.1377421991470.JavaMail.ngmail@webmail16.arcor-online.net>
In-Reply-To: <20130825050159.GH2882@elie.Belkin>

 
> >  
> > -Or you can use linkgit:git-name-rev[1], which will give the commit a
> > +or you can use linkgit:git-name-rev[1], which will give the commit a
> 
> I think this reads better with a capital 'O'.  (The pedant in me
> likes it, too, since a colon ends a sentence.)
> 
> The lowercase 'but' later in this section should perhaps also be
> capitalized, since it also starts an independent thought.
> 
> 	But that may sometimes help you guess which tags come after the
> 	given commit.
>

I am no native speaker, but I am a little reluctant to start a new sentence
with "But" or "Or". 

> The sentence "So, you can run something like ... then search for a
> line that looks like ..." is a sequence of incomplete thoughts.  It
> could be paraphrased a little to scan better:
> 
> 	So, if you run something like "git show-branch e05db0fd
> 	v1.5.0-rc0 v1.5.0-rc1 v1.5.0-rc2"
> 
> 		$ git show-branch e05db0fd v1.5.0-rc0 v1.5.0-rc1 v1.5.0-rc2
> 		! [e05db...
> 
> 	then a line like
> 
> 		+ ++ [e05db0fd] Fix warnings in ...
> 
> 	shows that e05db0fd is reachable from itself, from v1.5.0-rc1,
> 	and from v1.5.0-rc2, and not from v1.5.0-rc0.
> 

OK; thanks! I will add this.

> >  
> > -To see how submodule support works, create (for example) four example
> > +To see how submodule support works, create four example
> 
> I'd keep the joke.
>

I totally missed the joke ...


---
Thomas