From: David Turner <david.turner@twosigma.com>
Date: Fri, 30 Aug 2019 13:47:23 GMT
Subject: RE: [PATCH] clarify documentation for remote helpers
Message-ID: <88d9063060644dd99122bf0933f23fa9@exmbdft7.ad.twosigma.com>
In-Reply-To: <CAN0heSosCnn5msMX18YPwrKJzWkSWptWSFRunQdLE7T7Lc4-OA@mail.gmail.com>

I was confused, because I read "a file under GIT_DIR/objects/pack" to mean "just the filename".  Some of the things that deal with packs take just the filename (e.g. --keep-pack for git repack).  I'll fix the under under and add $, but I do want to clarify that it's the full path.

> -----Original Message-----
> From: Martin Ågren <martin.agren@gmail.com>
> Sent: Friday, August 30, 2019 12:03 AM
> To: David Turner <David.Turner@twosigma.com>
> Cc: Git Mailing List <git@vger.kernel.org>
> Subject: Re: [PATCH] clarify documentation for remote helpers
> 
> On Thu, 29 Aug 2019 at 23:06, David Turner <dturner@twosigma.com> wrote:
> 
> > -Optionally may output a 'lock <file>' line indicating a file under
> > -GIT_DIR/objects/pack which is keeping a pack until refs can be
> > -suitably updated.
> > +Optionally may output a 'lock <file>' line indicating the full path
> > +of a file under under GIT_DIR/objects/pack which is keeping a pack
> > +until refs can be suitably updated.  The path must end with ".keep".
> 
> "under under".
> 
> Also -- and I realize this is nothing new in your patch -- "GIT_DIR"
> should be prefixed with a '$' and that whole path wrapped in backticks so it
> gets monospaced. In total, my suggestion would be
> 
> -+a file under under GIT_DIR/objects/pack which is keeping a pack until
> ++a file under `$GIT_DIR/objects/pack` which is keeping a pack until
> 
> Whether what you're saying is actually *true*, sorry, no idea. I just have those
> nits above to offer.
> 
> Martin