From: Rubén Justo Date: Sun, 21 Apr 2024 10:27:06 GMT Subject: [PATCH 2/4] add-interactive: plug a leak in get_untracked_files Message-ID: <88b119aa-c1c2-435a-baaa-9422388bf0ec@gmail.com> In-Reply-To: Plug a leak we have since ab1e1cccaf (built-in add -i: re-implement `add-untracked` in C, 2019-11-29). This leak can be triggered with: $ echo a | git add -i As a curiosity, we have a somewhat similar function in builtin/stash.c, which correctly frees the memory. Signed-off-by: Rubén Justo --- add-interactive.c | 1 + 1 file changed, 1 insertion(+) diff --git a/add-interactive.c b/add-interactive.c index 6bf87e7ae7..e17602b5e4 100644 --- a/add-interactive.c +++ b/add-interactive.c @@ -865,6 +865,7 @@ static int get_untracked_files(struct repository *r, } strbuf_release(&buf); + dir_clear(&dir); return 0; } -- 2.45.0.rc0.4.g08f77eb516