From: Thomas Rast Date: Sat, 07 Dec 2013 16:35:44 GMT Subject: Re: [PATCH v3 16/21] repack: handle optional files created by pack-objects Message-ID: <87zjocippb.fsf@linux-1gf2.Speedport_W723_V_Typ_A_1_00_098> In-Reply-To: <20131114124605.GP10757@sigill.intra.peff.net> Jeff King writes: > We ask pack-objects to pack to a set of temporary files, and > then rename them into place. Some files that pack-objects > creates may be optional (like a .bitmap file), in which case > we would not want to call rename(). We already call stat() > and make the chmod optional if the file cannot be accessed. > We could simply skip the rename step in this case, but that > would be a minor regression in noticing problems with > non-optional files (like the .pack and .idx files). > > Instead, we can now annotate extensions as optional, and > skip them if they don't exist (and otherwise rely on > rename() to barf). > > Signed-off-by: Jeff King Reviewed-by: Thomas Rast -- Thomas Rast tr@thomasrast.ch